Accessibility: Use buttons for Add Themes sorting controls - #12848
Accessibility: Use buttons for Add Themes sorting controls#12848Sukhendu2002 wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the detailed review! I also verified mouse and Space-key activation, focus styling, and current/aria-current updates locally in Chromium, Firefox, including RTL and multiple admin color schemes. Since this view has no existing focused test coverage, I kept the PR scoped without adding a new harness. |
This PR fixes the incorrect semantics of the Add Themes sorting controls. These controls perform JavaScript actions but were marked up as links pointing to
#. They are now native buttons, providing the expected keyboard and assistive technology behavior.The JavaScript selectors and CSS have been updated to support the buttons while preserving the existing behavior and appearance.
This resolves the Add Themes-specific part of #26504.
Trac ticket: https://core.trac.wordpress.org/ticket/26504
Use of AI Tools
AI assistance: Yes
Tool(s): Pi coding agent
Model(s): GPT-5.6
Used for: Code analysis, code review and PR description generation. Final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.